Feat: Melihat subscription package #71
Conversation
nataniadeandra
requested review from
swastikanata,
catherineeangel,
JohannesSetiawan,
carlenee and
emiriko
src/redux/api/subscriptionApi.ts
Outdated
| providesTags: (result) => [ | ||
| { type: 'LatestSubscription', id: result?.id }, | ||
| 'LatestSubscription', | ||
| ], |
There was a problem hiding this comment.
From the documentation, it's always a great idea to check first whether result variable exist or not. You can refer it here:
https://redux-toolkit.js.org/rtk-query/usage/automated-refetching#providing-cache-data
src/app/package/page.tsx
Outdated
| const { data: free_package = {} as PackageDetailResponse } = | ||
| useGetPackageDetailQuery(1) | ||
| const { data: premium_package = {} as PackageDetailResponse } = | ||
| useGetPackageDetailQuery(2) |
There was a problem hiding this comment.
In my opinion, you can use variable for the number. I get what you are saying because 1 means package with id: 1. But what if the schema changes and id become UUID format, this will be hard to maintain, so you can refactor this to a constant.ts so that you don't have to change the main package list code.
constant.ts
export const PACKAGE = {
"free": 1,
"premium": 2
}
Then you can call these constant, such as PACKAGE["free"]
Feels free to have an opinion about my comments though!
There was a problem hiding this comment.
Have fixed! Please check 😃 @emiriko @JohannesSetiawan
This pull request introduces several updates to improve the user experience and provide more information to our users.
Changes Made: